-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use --max-opt=0 instead of --no-opt test-linux-perf.js #48862
Conversation
--no-opt only disables turbofan but other compilers may still be enabled, in that case we may not be able to find the interpreted frames if the function is compiled soon enough. Instead use --max-opt=0 which turns off all compilers.
hmm, so the test is still failing, I took a look at the logs again and I think --interpreted-frames-native-stack is actually broken - it was a bit confusing because the test concats the outputs together before testing them, so there are still compiled functions that you can see in the second part of the output, but if you check out the first part of the concatenated output, it's actually all "unknown". |
Although from local testing, I am able to get the interpreted names alright, so it might have something to do with the benchmark machine setup? |
I think this is not the right approach, because even |
--no-opt only disables turbofan but other compilers may still be enabled, in that case we may not be able to find the interpreted frames if the function is compiled soon enough. Instead use --max-opt=0 which turns off all compilers.
Refs: #48861